refactor: generate presets with css cascade layers #4894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #4796 CSS Cascade Layers are already widely support for almost 3 years. See https://developer.mozilla.org/en-US/docs/Web/CSS/@layer We can switch to it instead of wrapping selectors with `:where` all preset selectors. For older browsers impact will be insignificant as in most cases we use presets only to normalize browser styles. Generated code now looks like this ```css @layer presets { div.w-box { display: block; } } ```
kof
reviewed
Feb 19, 2025
johnsicili
approved these changes
Feb 19, 2025
kof
approved these changes
Feb 19, 2025
istarkov
pushed a commit
that referenced
this pull request
Feb 23, 2025
Closes #4796 CSS Cascade Layers are already widely support for almost 3 years. See https://developer.mozilla.org/en-US/docs/Web/CSS/@layer We can switch to it instead of wrapping selectors with `:where` all preset selectors. For older browsers impact will be insignificant as in most cases we use presets only to normalize browser styles. Generated code now looks like this ```css @layer presets { div.w-box { display: block; } } ``` Here's how presets look in chrome devtools. As you can see browser styles are defined as layer too. <img width="357" alt="Screenshot 2025-02-19 at 17 14 23" src="https://github.com/user-attachments/assets/473f2c0e-c7c5-4011-ba6b-4eeb1b805039" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4796
CSS Cascade Layers are already widely support for almost 3 years. See https://developer.mozilla.org/en-US/docs/Web/CSS/@layer
We can switch to it instead of wrapping selectors with
:whereall preset selectors.For older browsers impact will be insignificant as in most cases we use presets only to normalize browser styles.
Generated code now looks like this
Here's how presets look in chrome devtools. As you can see browser styles are defined as layer too.