Skip to content

Conversation

victorchrollo14
Copy link
Contributor

Description

closes ( #4203 )

  • added a new crop svg to icons package and generated the cropIcon component.
  • replaced the eye icon with the crop icon and also changed hidden to clip in the overflow toggle group.

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov self-requested a review March 4, 2025 10:41
@istarkov
Copy link
Member

istarkov commented Mar 4, 2025

Super, last 2 weeks I had 2 serious issues with hidden vs clip!!!

@istarkov
Copy link
Member

istarkov commented Mar 4, 2025

The only issue is the builder and clipped content.
In case of hidden scroll on instance select is working, in case of clip there is no scroll.
So clipped content will always be invisible.

@istarkov istarkov requested a review from kof March 4, 2025 10:49
@kof
Copy link
Member

kof commented Mar 4, 2025

@istarkov ohh, we actually have a use case with the slider where we use overflow hidden and scroll to the right image from the navigator thanks to overflow hidden.

@istarkov
Copy link
Member

istarkov commented Mar 4, 2025

Same usecase ruined some animations if hidden is set ;)
Its a builder logic issue.

@istarkov
Copy link
Member

istarkov commented Mar 4, 2025

What if only in the builder if element is selected we temporary replace clip on hidden for all ancestors. In case of no animations are in progress.

@kof
Copy link
Member

kof commented Mar 4, 2025

What if only in the builder if element is selected we temporary replace clip on hidden for all ancestors. In case of no animations are in progress.

will probably sooner or later lead to a situation where something is broken in that particular state, e.g. if something relies on clip but hidden is used instead

@TrySound TrySound force-pushed the replace-overflow-hidden branch from ccf30e1 to a46cae7 Compare March 27, 2025 09:03
@kof kof mentioned this pull request Mar 27, 2025
7 tasks
@kof kof temporarily deployed to development March 27, 2025 10:58 — with GitHub Actions Inactive
@kof kof temporarily deployed to development March 27, 2025 10:58 — with GitHub Actions Inactive
@kof kof temporarily deployed to development March 27, 2025 10:58 — with GitHub Actions Inactive
@kof kof temporarily deployed to development March 27, 2025 10:58 — with GitHub Actions Inactive
@TrySound
Copy link
Member

We agreed to get rid of "scroll" and keep both "clip" and "hidden" Caz both have use cases with animations

@TrySound TrySound changed the title feat: replaced overflow hidden with clip in styles panel (#4203) feat: add overflow clip in styles panel (#4203) Apr 29, 2025
@TrySound TrySound changed the title feat: add overflow clip in styles panel (#4203) feat: add overflow clip in styles panel Apr 29, 2025
@TrySound TrySound merged commit 7fa57b2 into webstudio-is:main Apr 29, 2025
9 of 11 checks passed
@TrySound
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants