Skip to content

fix: Fix local token clickable area #4922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025
Merged

fix: Fix local token clickable area #4922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2abc520
fix jumping of local style source when editing text on a token
kof Feb 27, 2025
408d244
making clickable surface of local complete size of the button
kof Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions apps/builder/app/builder/features/style-panel/style-source/style-source-control.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,20 +318,13 @@ export const StyleSourceControl = ({
disabled={disabled}
aria-current={selected && state === undefined}
role="button"
onClick={onSelect}
hasError={error !== undefined}
>
<Flex
grow
css={{
position: "relative",
paddingBlock: theme.spacing[3],
paddingInline: theme.spacing[4],
}}
>
<Flex grow css={{ padding: theme.spacing[2] }}>
<StyleSourceButton
disabled={disabled || isEditing}
isEditing={isEditing}
onClick={onSelect}
tabIndex={-1}
>
<Flex align="center" justify="center" gap="1">
Expand Down
42 changes: 20 additions & 22 deletions apps/builder/app/builder/features/style-panel/style-source/style-source-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,28 +204,26 @@ const TextFieldBase: ForwardRefRenderFunction<
onKeyDown={onKeyDown}
>
{/* We want input to be the first element in DOM so it receives the focus first */}
{editingItemId === undefined && (
<InputField
{...textFieldProps}
variant="chromeless"
css={{
fontVariantNumeric: "tabular-nums",
lineHeight: 1,
order: 1,
flex: 1,
"&:focus-within, &:hover": {
borderColor: "transparent",
},
}}
size="1"
value={label}
onClick={onClick}
ref={inputRef}
inputRef={internalInputRef}
spellCheck={false}
aria-label="New Style Source Input"
/>
)}
<InputField
{...textFieldProps}
variant="chromeless"
css={{
fontVariantNumeric: "tabular-nums",
lineHeight: 1,
order: 1,
flex: 1,
"&:focus-within, &:hover": {
borderColor: "transparent",
},
}}
size="1"
value={label}
onClick={onClick}
ref={inputRef}
inputRef={internalInputRef}
spellCheck={false}
aria-label="New Style Source Input"
/>
{value.map((item) => (
<StyleSourceControl
key={item.id}
Expand Down
Loading