fix: navigate hash urls natively #4929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4830 Remix incorrectly navigates hashes and clear search params. Here fixed this by using native `<a>` and tweaked the logic in builder.
TrySound
force-pushed
the
fragment-links.staging
branch
from
9f171e9 to
714e2d2
Compare
|
Hey this actually fixes #3974 :) The only problem I'm seeing is the query params are stripped still. Am I doing something wrong? noqueryparams.mp4 |
|
Ah, right. Well page+id selector still doesn't work because it relies on specific page. And when you put for example into slot we cannot use "current page matches specified one" heuristic. But "#my-id" string url should work. |
johnsicili
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4830
Remix incorrectly navigates hashes and clear search params. Here fixed this by using native
<a>and tweaked the logic in builder.Test navigating hashes (when search params are present) in builder and on published site.