Skip to content

fix: Fixes 2 bugs in advanced panel #4935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2025
Merged

fix: Fixes 2 bugs in advanced panel #4935

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcbe7bb
copy recent properties as well when copy all
kof Feb 28, 2025
57a0508
focus previous style input after deleting
kof Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions apps/builder/app/builder/features/style-panel/sections/advanced/advanced.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ export const Section = () => {
setSearchProperties(matched as CssProperty[]);
};

const afterAddingStyles = () => {
const afterChangingStyles = () => {
setIsAdding(false);
requestAnimationFrame(() => {
// We are either focusing the last value input from the recent list if available or the search input.
Expand All @@ -476,7 +476,7 @@ export const Section = () => {
</Box>
<CopyPasteMenu
onPaste={handleInsertStyles}
properties={currentProperties}
properties={[...recentProperties, ...currentProperties]}
>
<Flex gap="2" direction="column">
<Flex
Expand All @@ -502,6 +502,7 @@ export const Section = () => {
(recentProperty) => recentProperty !== property
)
);
afterChangingStyles();
}}
/>
);
Expand All @@ -519,10 +520,10 @@ export const Section = () => {
onSubmit={(cssText: string) => {
const styles = handleInsertStyles(cssText);
if (styles.size > 0) {
afterAddingStyles();
afterChangingStyles();
}
}}
onClose={afterAddingStyles}
onClose={afterChangingStyles}
onFocus={() => {
if (isAdding === false) {
handleShowAddStyleInput();
Expand Down