fix: og-image bug fix for local assets #5184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when a project is exported using
cli
and the built using any inbuilt templates. Theog:image
fails with local assets. As the cli is not prefixing theassetBaseUrl
to the image name. Which is failing to load.Bug
Deployed Url - https://og-image-bug.netlify.app/

Open GH - https://orcascan.com/tools/open-graph-validator?url=https%3A%2F%2Fog-image-bug.netlify.app%2F
Fixed version
Deployed url - https://og-image-fix.netlify.app/

Open GH - https://orcascan.com/tools/open-graph-validator?url=https%3A%2F%2Fog-image-fix.netlify.app%2F
I am passing the
assetBaseUrl
toProjectSettingsMeta
inside thereact-sdk
. And using it as prefix if defined.Steps for reproduction
SocialImage
section under Page Settings.og:image
to kick in when shared.Code Review
Before requesting a review
Before merging