Skip to content

Conversation

JayaKrishnaNamburu
Copy link
Contributor

Description

Currently when a project is exported using cli and the built using any inbuilt templates. The og:image fails with local assets. As the cli is not prefixing the assetBaseUrl to the image name. Which is failing to load.

Bug

Deployed Url - https://og-image-bug.netlify.app/
Open GH - https://orcascan.com/tools/open-graph-validator?url=https%3A%2F%2Fog-image-bug.netlify.app%2F
Screenshot 2025-05-05 at 6 18 20 PM

Fixed version

Deployed url - https://og-image-fix.netlify.app/
Open GH - https://orcascan.com/tools/open-graph-validator?url=https%3A%2F%2Fog-image-fix.netlify.app%2F
Screenshot 2025-05-05 at 6 19 06 PM

I am passing the assetBaseUrl to ProjectSettingsMeta inside the react-sdk. And using it as prefix if defined.

Steps for reproduction

  • Create a project and add a page to it.
  • Upload and use an image for the SocialImage section under Page Settings.
  • Deploy the site, and share it anywhere for the og:image to kick in when shared.

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review

Before merging

  • tested locally and on preview environment (preview dev login: 0000)

@kof kof requested a review from TrySound May 5, 2025 13:40
@JayaKrishnaNamburu JayaKrishnaNamburu self-assigned this May 5, 2025
@TrySound TrySound merged commit be6b5fa into main May 5, 2025
17 checks passed
@TrySound TrySound deleted the fix-og-image branch May 5, 2025 15:21
@TrySound
Copy link
Member

TrySound commented May 5, 2025

Great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants