Skip to content

fix: default twitter og preview to use big card #5191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: default twitter og preview to use big card #5191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cdad25
fix: default twitter og preview to use big card
JayaKrishnaNamburu May 6, 2025
b2f694f
rename twitter:card size check for readability
JayaKrishnaNamburu May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions fixtures/ssg-netlify-by-project-id/pages/index/+Head.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ export const Head = ({ data }: { data: PageContext["data"] }) => {
format: "raw",
})}`;
}
const isTwitterCardSizeDefined = pageMeta.custom.some(
(meta) => meta.property === "twitter:card"
);
return (
<>
{data.url && <meta property="og:url" content={data.url} />}
Expand Down Expand Up @@ -55,6 +58,11 @@ export const Head = ({ data }: { data: PageContext["data"] }) => {
{pageMeta.custom.map(({ property, content }) => (
<meta key={property} property={property} content={content} />
))}
{(pageMeta.socialImageAssetName !== undefined ||
pageMeta.socialImageUrl !== undefined) &&
isTwitterCardSizeDefined === false && (
<meta property="twitter:card" content="summary_large_image" />
)}

{favIconAsset && (
<link
Expand Down
8 changes: 8 additions & 0 deletions fixtures/ssg/pages/another-page/+Head.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ export const Head = ({ data }: { data: PageContext["data"] }) => {
format: "raw",
})}`;
}
const isTwitterCardSizeDefined = pageMeta.custom.some(
(meta) => meta.property === "twitter:card"
);
return (
<>
{data.url && <meta property="og:url" content={data.url} />}
Expand Down Expand Up @@ -55,6 +58,11 @@ export const Head = ({ data }: { data: PageContext["data"] }) => {
{pageMeta.custom.map(({ property, content }) => (
<meta key={property} property={property} content={content} />
))}
{(pageMeta.socialImageAssetName !== undefined ||
pageMeta.socialImageUrl !== undefined) &&
isTwitterCardSizeDefined === false && (
<meta property="twitter:card" content="summary_large_image" />
)}

{favIconAsset && (
<link
Expand Down
8 changes: 8 additions & 0 deletions fixtures/ssg/pages/index/+Head.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ export const Head = ({ data }: { data: PageContext["data"] }) => {
format: "raw",
})}`;
}
const isTwitterCardSizeDefined = pageMeta.custom.some(
(meta) => meta.property === "twitter:card"
);
return (
<>
{data.url && <meta property="og:url" content={data.url} />}
Expand Down Expand Up @@ -55,6 +58,11 @@ export const Head = ({ data }: { data: PageContext["data"] }) => {
{pageMeta.custom.map(({ property, content }) => (
<meta key={property} property={property} content={content} />
))}
{(pageMeta.socialImageAssetName !== undefined ||
pageMeta.socialImageUrl !== undefined) &&
isTwitterCardSizeDefined === false && (
<meta property="twitter:card" content="summary_large_image" />
)}

{favIconAsset && (
<link
Expand Down
8 changes: 8 additions & 0 deletions packages/cli/templates/ssg/app/route-templates/html/+Head.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ export const Head = ({ data }: { data: PageContext["data"] }) => {
format: "raw",
})}`;
}
const isTwitterCardSizeDefined = pageMeta.custom.some(
(meta) => meta.property === "twitter:card"
);
return (
<>
{data.url && <meta property="og:url" content={data.url} />}
Expand Down Expand Up @@ -55,6 +58,11 @@ export const Head = ({ data }: { data: PageContext["data"] }) => {
{pageMeta.custom.map(({ property, content }) => (
<meta key={property} property={property} content={content} />
))}
{(pageMeta.socialImageAssetName !== undefined ||
pageMeta.socialImageUrl !== undefined) &&
isTwitterCardSizeDefined === false && (
<meta property="twitter:card" content="summary_large_image" />
)}

{favIconAsset && (
<link
Expand Down
11 changes: 11 additions & 0 deletions packages/react-sdk/src/page-settings-meta.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,5 +137,16 @@ export const PageSettingsMeta = ({

metas.push(...pageMeta.custom);

const isTwitterCardSizeDefined = pageMeta.custom.some(
(meta) => meta.property === "twitter:card"
);
if (
(pageMeta.socialImageAssetName !== undefined ||
pageMeta.socialImageUrl !== undefined) &&
isTwitterCardSizeDefined === false
) {
metas.push({ property: "twitter:card", content: "summary_large_image" });
}

return metas.map((meta, index) => <Meta key={index} {...meta} />);
};
Loading