Skip to content

fix: handle autoplay property in youtube and vimeo #5211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: handle autoplay property in youtube and vimeo #5211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/sdk-components-react/src/vimeo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,8 @@ type Props = Omit<ComponentProps<typeof defaultTag>, keyof VimeoOptions> &
* Example: "Video about web development tips".
*/
title?: string | undefined;
// temporary prop until props render is fixed
autoPlay?: boolean;
};
type Ref = ElementRef<typeof defaultTag>;

Expand All @@ -360,7 +362,8 @@ export const Vimeo = forwardRef<Ref, Props>(
{
url,
loading = "lazy",
autoplay = false,
autoPlay,
autoplay = autoPlay ?? false,
autopause = true,
showByline = false,
showControls = true,
Expand Down
5 changes: 4 additions & 1 deletion packages/sdk-components-react/src/youtube.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,8 @@ type Props = Omit<
* Example: "Video about web development tips".
*/
title?: string | undefined;
// temporary prop until props render is fixed
autoPlay?: boolean;
};
type Ref = ElementRef<typeof defaultTag>;

Expand All @@ -478,7 +480,8 @@ export const YouTube = forwardRef<Ref, Props>(
{
url,
loading = "lazy",
autoplay,
autoPlay,
autoplay = autoPlay ?? false,
showPreview,
showAnnotations,
showCaptions,
Expand Down