perf: improve instance selection performance #5240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have html element mutations in a few places and each can add ~250ms of repaint time on large projects. Here I got rid of it in two places 1. Collapsed logic enforced document height to preserve scroll position. Instead I created an absolutely positioned div which enforced scroll where collapsed elements are reset. 2. Scroll into view logic defined position absolute on scroll container. Though it's not necessary on html element so just ignored it.
kof
reviewed
May 30, 2025
kof
approved these changes
May 30, 2025
|
Tested on the HugeProject if you search for it in dashboard we have one, the difference in performance is HUGE. |
TrySound
added a commit
that referenced
this pull request
Jun 4, 2025
We have html element mutations in a few places and each can add ~250ms of repaint time on large projects. Here I got rid of it in two places 1. Collapsed logic enforced document height to preserve scroll position. Instead I created an absolutely positioned div which enforced scroll where collapsed elements are reset. 2. Scroll into view logic defined position absolute on scroll container. Though it's not necessary on html element so just ignored it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have html element mutations in a few places and each can add ~250ms of repaint time on large projects. Here I got rid of it in two places