Skip to content

Conversation

TrySound
Copy link
Member

@TrySound TrySound commented Jun 3, 2025

Ref #3632

This can be a nice addition and a way to migrate legacy components.

replace-with-element.mp4

@TrySound TrySound requested a review from kof June 3, 2025 19:19
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceeee! What happens if one changes from a link to a div with href attribute?

@kof
Copy link
Member

kof commented Jun 4, 2025

Oh I see it keeps the attribute. User needs to remove bad attributes manually.

@TrySound
Copy link
Member Author

TrySound commented Jun 4, 2025

In html all attributes are good 😇

@TrySound TrySound merged commit 14e6ced into main Jun 4, 2025
17 checks passed
@TrySound TrySound deleted the replace branch June 4, 2025 08:56
@kof
Copy link
Member

kof commented Jun 4, 2025

In html all attributes are good 😇

I mean invalid, can't put href on a div for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants