Skip to content

chore: Add add via=badge parameter to made with webstudio #5245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

chore: Add add via=badge parameter to made with webstudio #5245

merged 1 commit into from
Jun 6, 2025

Conversation

kof
Copy link
Member

@kof kof commented Jun 6, 2025

Description

So we can know how well this is working

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof temporarily deployed to development June 6, 2025 19:17 — with GitHub Actions Inactive
@kof kof merged commit 9d6cac5 into main Jun 6, 2025
17 checks passed
@kof kof deleted the via-badge branch June 6, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kof @TrySound