Skip to content

fix: Improve made with webstudio badge tooltip #5266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

fix: Improve made with webstudio badge tooltip #5266

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3a20b8
improve badge tip
kof Jun 10, 2025
d4c1357
only check the webstudio link without the badge
kof Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/builder/app/builder/features/topbar/publish.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ const $usedProFeatures = computed(
const badgeFeature = 'No "Built with Webstudio" badge';
// Badge should be rendered on free sites on every page.
features.set(badgeFeature, {
info: "Adding the badge to your homepage helps us offer a free version of the service. Please open the Components panel by clicking the “+” icon on the left, and add the “Built with Webstudio” component to your page. Feel free to adjust the badge’s styles to match your design.",
info: "Adding the badge to your homepage helps us offer a free version of the service. Please open the Components panel by clicking the “+” icon on the left, and add the “Built with Webstudio” component to your page. Feel free to adjust the badge's style to match your design - after all, it's just a link, and you can place it wherever you like.",
});
// We want to check the badge only on the home page
const homePageInstanceIds = findTreeInstanceIds(
Expand All @@ -288,7 +288,8 @@ const $usedProFeatures = computed(
for (const prop of props ?? []) {
if (
prop.name === "href" &&
prop.value === "https://webstudio.is/?via=badge"
typeof prop.value === "string" &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prop.type === 'string' would work too

prop.value.includes("https://webstudio.is")
) {
features.delete(badgeFeature);
}
Expand Down