Skip to content

fix: catch iframe errors #5279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2025
+18 −8
Merged

fix: catch iframe errors #5279

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3365779
fix: catch iframe errors
TrySound Jun 14, 2025
c282c21
Log error
TrySound Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions apps/builder/app/shared/sync-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,15 @@ export class ImmerhinSyncObject implements SyncObject {
}
setState(state: Map<string, unknown>) {
for (const [namespace, $store] of this.store.containers) {
// Immer cannot handle Map instances from another realm.
// Use `clone` to recreate the data with the current realm's classes.
// This works because the structured clone algorithm skips prototype chains; classes must be defined in both realms.
$store.set(structuredClone(state.get(namespace)));
// catch errors triggered by CSP configuration when user put iframe onto canvas
try {
// Immer cannot handle Map instances from another realm.
// Use `clone` to recreate the data with the current realm's classes.
// This works because the structured clone algorithm skips prototype chains; classes must be defined in both realms.
$store.set(structuredClone(state.get(namespace)));
} catch (error) {
console.error(error);
}
}
}
applyTransaction(transaction: Transaction<Change[]>) {
Expand Down Expand Up @@ -112,10 +117,15 @@ export class NanostoresSyncObject implements SyncObject {
}
applyTransaction(transaction: Transaction) {
this.operation = "add";
// `instanceof` checks do not work with instances like Map, File, etc., from another realm.
// Use `clone` to recreate the data with the current realm's classes.
// This works because the structured clone algorithm skips prototype chains; classes must be defined in both realms.
this.store.set(structuredClone(transaction.payload));
// catch errors triggered by CSP configuration when user put iframe onto canvas
try {
// `instanceof` checks do not work with instances like Map, File, etc., from another realm.
// Use `clone` to recreate the data with the current realm's classes.
// This works because the structured clone algorithm skips prototype chains; classes must be defined in both realms.
this.store.set(structuredClone(transaction.payload));
} catch (error) {
console.error(error);
}
this.operation = "local";
}
revertTransaction(_transaction: RevertedTransaction) {
Expand Down