Skip to content

Conversation

kof
Copy link
Member

@kof kof commented Jun 17, 2025

Description

image
  1. What is this PR about (link the issue and add a short description)

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from TrySound June 17, 2025 15:01
Comment on lines 884 to 885
//const { hasProPlan } = useStore($userPlanFeatures);
const hasProPlan = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncomment

return (
<CollapsibleDomainSection
title={pageUrl.host}
title={new URL(publishedOrigin).host}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you reverted this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shit, must be something wasn't updated before I started

@kof kof temporarily deployed to development June 17, 2025 15:15 — with GitHub Actions Inactive
@kof kof closed this Jun 17, 2025
@TrySound TrySound deleted the upgrade-banner-clarity branch June 26, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants