Skip to content

feat: open page settings when click on publish blockers #5290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

feat: open page settings when click on publish blockers #5290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac6384b
feat: open page settings when click on publish blockers
TrySound Jun 22, 2025
4463bdd
Remove log
TrySound Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions apps/builder/app/builder/features/topbar/publish.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,18 @@ import {
import {
$authTokenPermissions,
$dataSources,
$editingPageId,
$instances,
$pages,
$project,
$propsIndex,
$publishedOrigin,
$userPlanFeatures,
} from "~/shared/nano-states";
import { $publishDialog } from "../../shared/nano-states";
import {
$publishDialog,
setActiveSidebarPanel,
} from "../../shared/nano-states";
import { Domains, PENDING_TIMEOUT, getPublishStatusAndText } from "./domains";
import { CollapsibleDomainSection } from "./collapsible-domain-section";
import {
Expand Down Expand Up @@ -242,7 +246,8 @@ const $usedProFeatures = computed(
(pages, dataSources, instances, propsIndex, styleObjectModel) => {
const features = new Map<
string,
undefined | { awareness?: Awareness; info?: ReactNode }
| undefined
| { awareness?: Awareness; view?: "pageSettings"; info?: ReactNode }
>();
if (pages === undefined) {
return features;
Expand All @@ -258,13 +263,13 @@ const $usedProFeatures = computed(
instanceSelector: [page.rootInstanceId],
};
if (isPathnamePattern(page.path)) {
features.set("Dynamic path", { awareness });
features.set("Dynamic path", { awareness, view: "pageSettings" });
}
if (page.meta.status && page.meta.status !== `200`) {
features.set("Page status code", { awareness });
features.set("Page status code", { awareness, view: "pageSettings" });
}
if (page.meta.redirect && page.meta.redirect !== `""`) {
features.set("Redirect", { awareness });
features.set("Redirect", { awareness, view: "pageSettings" });
}
}
// has resource variables
Expand Down Expand Up @@ -824,14 +829,20 @@ const UpgradeBanner = () => {
<Text variant="regularBold">Following Pro features are used:</Text>
<Text as="ul" color="destructive" css={{ paddingLeft: "1em" }}>
{Array.from(usedProFeatures).map(
([message, { awareness, info } = {}], index) => (
([message, { awareness, view, info } = {}], index) => (
<li key={index}>
<Flex align="center" gap="1">
{awareness ? (
<button
className={buttonLinkClass}
type="button"
onClick={() => $awareness.set(awareness)}
onClick={() => {
$awareness.set(awareness);
if (view === "pageSettings") {
setActiveSidebarPanel("pages");
$editingPageId.set(awareness.pageId);
}
}}
>
{message}
</button>
Expand Down