fix: add .editorconfig to fix error due to line endings on Windows #5292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git Attributes file to ensure that line endings are the same regardless of the OS (This was causing problems for Windows + Docker)
TrySound
reviewed
Jun 27, 2025
|
Seems like other popular repos have lf configured in .editorconfig. Can you please try if it works? https://github.com/sveltejs/svelte/blob/main/.editorconfig#L1-L4 |
|
https://github.com/search?q=repo%3Afacebook%2Freact%20gitattributes&type=code Most libs does not have this at all. Also we can't somehow test this as no one of devs have windows. |
|
IMO should be short like React if needed |
TrySound
reviewed
Jun 27, 2025
TrySound
reviewed
Jun 27, 2025
Changed editor.config to .editorconfig and removed unnecessary code
|
@TrySound ok I changed what you said. looks like it still works. |
TrySound
approved these changes
Jun 27, 2025
TrySound
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Git Attributes file to ensure that line endings are the same regardless of the OS (This was causing problems for Windows + Docker)
Steps for reproduction (Windows)
Code Review
hi @kof, I need you to take a look and make sure this is an ideal fix
It seems to work great on my end.