Skip to content

fix: Reduce range units #5300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix: Reduce range units #5300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
23768a8
feat: reduced units list in animation UI
mohitfrontenddev Jun 27, 2025
f9b12cc
Fix: update RANGE_UNITS and regenerate units.ts
mohitfrontenddev Jun 27, 2025
5ea56df
Limit RANGE_UNITS to % and px only
mohitfrontenddev Jun 27, 2025
f260d2e
fix: replace dvh units with % to match reduced RANGE_UNITS
mohitfrontenddev Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...lder/app/builder/features/settings-panel/props-section/animation/new-scroll-animations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ const newFadeInScrollAnimation: ScrollAnimation = {
description: "Fade in the element as it scrolls into view.",

timing: {
rangeStart: ["start", { type: "unit", value: 0, unit: "%" }],
rangeEnd: ["start", { type: "unit", value: 50, unit: "dvh" }],
rangeStart: ["start", { type: "unit", value: 0, unit: "px" }],
rangeEnd: ["start", { type: "unit", value: 50, unit: "px" }],
fill: "backwards",
easing: "linear",
},
Expand All @@ -45,8 +45,8 @@ const newFadeOutScrollAnimation: ScrollAnimation = {
description: "Fade out the element as it scrolls out of view.",

timing: {
rangeStart: ["end", { type: "unit", value: 50, unit: "dvh" }],
rangeEnd: ["end", { type: "unit", value: 0, unit: "%" }],
rangeStart: ["end", { type: "unit", value: 50, unit: "px" }],
rangeEnd: ["end", { type: "unit", value: 0, unit: "px" }],
fill: "backwards",
easing: "linear",
},
Expand Down
45 changes: 1 addition & 44 deletions packages/sdk/src/schema/animation-schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,50 +12,7 @@ const literalUnion = <T extends readonly string[]>(arr: T) =>
);

// Range Units
export const RANGE_UNITS = [
"%",
"px",
"cm",
"mm",
"q",
"in",
"pt",
"pc",
"em",
"rem",
"ex",
"rex",
"cap",
"rcap",
"ch",
"rch",
"lh",
"rlh",
"vw",
"svw",
"lvw",
"dvw",
"vh",
"svh",
"lvh",
"dvh",
"vi",
"svi",
"lvi",
"dvi",
"vb",
"svb",
"lvb",
"dvb",
"vmin",
"svmin",
"lvmin",
"dvmin",
"vmax",
"svmax",
"lvmax",
"dvmax",
] as const;
export const RANGE_UNITS = ["%", "px"] as const;

export const rangeUnitSchema = literalUnion(RANGE_UNITS);

Expand Down