Skip to content

fix: avoid body when insert section from marketplace #5329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

fix: avoid body when insert section from marketplace #5329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions apps/builder/app/builder/features/marketplace/templates.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
import { ChevronLeftIcon, ExternalLinkIcon } from "@webstudio-is/icons";
import {
elementComponent,
Instance,
ROOT_FOLDER_ID,
type Asset,
type Page,
Expand All @@ -33,6 +34,10 @@ import { Card } from "./card";
import type { MarketplaceOverviewItem } from "~/shared/marketplace/types";
import { selectPage } from "~/shared/awareness";

const isBody = (instance: Instance) =>
instance.component === "Body" ||
(instance.component === elementComponent && instance.tag === "body");

/**
* Insert page as a template.
* - Currently only supports inserting everything from the body
Expand All @@ -46,17 +51,12 @@ const insertSection = ({
instanceId: string;
}) => {
const fragment = extractWebstudioFragment(data, instanceId);
const body = fragment.instances.find(
(instance) => instance.component === "Body"
);
const body = fragment.instances.find(isBody);
// remove body and use its children as root insrances
if (body) {
fragment.instances = fragment.instances.filter((instance) => {
const isBody =
instance.component === "Body" ||
(instance.component === elementComponent && instance.tag === "body");
return !isBody;
});
fragment.instances = fragment.instances.filter(
(instance) => !isBody(instance)
);
fragment.children = body.children;
}
const insertable = findClosestInsertable(fragment);
Expand Down