Skip to content

fix: support older browsers in docker template #5346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2025
Merged

fix: support older browsers in docker template #5346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion fixtures/react-router-docker/app/constants.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,19 @@
*/
export const assetBaseUrl = "/assets/";

/**
* URL.canParse(props.src)
* @type {(url: string) => boolean}
*/
const UrlCanParse = (url) => {
try {
new URL(url);
return true;
} catch {
return false;
}
};

/**
* @type {import("@webstudio-is/image").ImageLoader}
*/
Expand All @@ -12,7 +25,7 @@ export const imageLoader = (props) => {
return props.src;
}
// handle absolute urls
const path = URL.canParse(props.src) ? `/${props.src}` : props.src;
const path = UrlCanParse(props.src) ? `/${props.src}` : props.src;
// https://github.com/unjs/ipx?tab=readme-ov-file#modifiers
return `/_image/w_${props.width},q_${props.quality}${path}`;
};
15 changes: 14 additions & 1 deletion packages/cli/templates/react-router-docker/app/constants.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,19 @@
*/
export const assetBaseUrl = "/assets/";

/**
* URL.canParse(props.src)
* @type {(url: string) => boolean}
*/
const UrlCanParse = (url) => {
try {
new URL(url);
return true;
} catch {
return false;
}
};

/**
* @type {import("@webstudio-is/image").ImageLoader}
*/
Expand All @@ -12,7 +25,7 @@ export const imageLoader = (props) => {
return props.src;
}
// handle absolute urls
const path = URL.canParse(props.src) ? `/${props.src}` : props.src;
const path = UrlCanParse(props.src) ? `/${props.src}` : props.src;
// https://github.com/unjs/ipx?tab=readme-ov-file#modifiers
return `/_image/w_${props.width},q_${props.quality}${path}`;
};
Loading