Skip to content

fix: avoid optimizing .ico in docker template #5368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2025
Merged

fix: avoid optimizing .ico in docker template #5368

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff009df
fix: avoid optimizing .ico in docker template
TrySound Aug 11, 2025
b1e6e66
Fix fixtures
TrySound Aug 11, 2025
d767c02
Format code
TrySound Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions fixtures/react-router-docker/app/constants.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ export const imageLoader = (props) => {
if (props.format === "raw") {
return props.src;
}
// IPX (sharp) does not support ico
if (props.src.endsWith('.ico')) {
return props.src;
}
// handle absolute urls
const path = UrlCanParse(props.src) ? `/${props.src}` : props.src;
// https://github.com/unjs/ipx?tab=readme-ov-file#modifiers
Expand Down
4 changes: 4 additions & 0 deletions packages/cli/templates/react-router-docker/app/constants.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ export const imageLoader = (props) => {
if (props.format === "raw") {
return props.src;
}
// IPX (sharp) does not support ico
if (props.src.endsWith('.ico')) {
return props.src;
}
// handle absolute urls
const path = UrlCanParse(props.src) ? `/${props.src}` : props.src;
// https://github.com/unjs/ipx?tab=readme-ov-file#modifiers
Expand Down
Loading