Skip to content

fix: handle headers in graphql resource #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2025
Merged

fix: handle headers in graphql resource #5395

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e28fb0
fix: handle headers in graphql resource
TrySound Sep 7, 2025
c49b838
Fix resource preview
TrySound Sep 8, 2025
44228cb
Fix reload and sitemap resource
TrySound Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions apps/builder/app/builder/features/settings-panel/resource-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,10 @@ const parseHeaders = (headers: Resource["headers"]) => {
let maxAge: undefined | string;
let bodyType: BodyType;
const newHeaders = headers.filter((header) => {
const value = computeExpression(header.value, new Map()).toLowerCase();
// cast raw expression result to string
const value = String(
computeExpression(header.value, new Map())
).toLowerCase();
if (isCacheControl(header.name)) {
// move simple header like Cache-Control: max-age=10 to dedicated input
// preserve more complex cache-control
Expand All @@ -818,7 +821,7 @@ const parseHeaders = (headers: Resource["headers"]) => {
return false;
}
}
return false;
return true;
});
return { headers: newHeaders, maxAge, bodyType };
};
Expand Down Expand Up @@ -1129,10 +1132,9 @@ export const GraphqlResourceForm = forwardRef<
control: "graphql",
url,
method: "post",
headers: [
...headers,
{ name: "Content-Type", value: "application/json" },
],
headers: headers.some(({ name }) => isContentType(name))
? headers
: [...headers, { name: "Content-Type", value: `"application/json"` }],
body,
};
const newVariable: DataSource = {
Expand Down
Loading