Skip to content

fix: icon and description for expand/collapse all items in keyboard shorcuts dialog#5535

Merged
kof merged 6 commits intowebstudio-is:mainfrom
bonsak:fix/icon-and-description-for-Expand-all-items-in-shorcuts-dialog
Dec 29, 2025
Merged

fix: icon and description for expand/collapse all items in keyboard shorcuts dialog#5535
kof merged 6 commits intowebstudio-is:mainfrom
bonsak:fix/icon-and-description-for-Expand-all-items-in-shorcuts-dialog

Conversation

@bonsak
Copy link
Contributor

@bonsak bonsak commented Dec 21, 2025

Description

  1. This pull request fixes the description of keyboard shortcut for expand / collapse of navigator items. The working shortcut for expand/collapse navigator items are alt + click on both osx and windows. But is listed in the Keyboard shortcuts dialog as ⌘ + click on osx and CTRL + click on windows.
  2. This PR also changes the description of the shortcut to be more inline with other shortcuts for navigator items.

Steps for reproduction

  1. Open any project
  2. Open the Keyboard shortcuts menu
  • On OSX, the expand / collapse navigator items is listed as ⌘ + click
  • On WIN, the shortcut is listed as CTRL + click

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@bonsak bonsak changed the title Fix/icon and description for expand/collapse all items in keyboard shorcuts dialog fix: icon and description for expand/collapse all items in keyboard shorcuts dialog Dec 21, 2025
@kof
Copy link
Member

kof commented Dec 22, 2025

thank you

@bonsak
Copy link
Contributor Author

bonsak commented Dec 22, 2025

I don't know why the Lost Pixel tests are failing. Any pointers on how i can fix this PR so it might pass these tests?

Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just apply this, good to go otherwise

@bonsak
Copy link
Contributor Author

bonsak commented Dec 28, 2025

just apply this, good to go otherwise

Edit made. Lost pixel checks are still failing. Not sure how to solve this.

@kof kof merged commit 2f14013 into webstudio-is:main Dec 29, 2025
9 of 11 checks passed
@bonsak bonsak deleted the fix/icon-and-description-for-Expand-all-items-in-shorcuts-dialog branch December 30, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants