Skip to content

fix: Bring back upload button in several cases#5549

Merged
kof merged 1 commit intomainfrom
upload-button
Dec 30, 2025
Merged

fix: Bring back upload button in several cases#5549
kof merged 1 commit intomainfrom
upload-button

Conversation

@kof
Copy link
Member

@kof kof commented Dec 30, 2025

Description

Regression, button for upload was removed in case of favicon, page settings, marketplace settings

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof merged commit 0e4d76d into main Dec 30, 2025
15 of 17 checks passed
@kof kof deleted the upload-button branch December 30, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant