Skip to content

Disable devtools of webview under release mode #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlbertShown merged 3 commits into from
Apr 9, 2025
Merged

Disable devtools of webview under release mode #582

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12c39c5
Feat: disabling WebView2 devtools on Windows.
konakona418 Apr 9, 2025
80e896f
Merge branch 'webui-dev:main' into disable-webui-devtools
konakona418 Apr 9, 2025
0947e86
Feat: simplified implementation of disabling devtools on Windows.
konakona418 Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/webui.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11221,6 +11221,15 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpReserved) {
settings->lpVtbl->put_IsScriptEnabled(settings, TRUE);
settings->lpVtbl->put_AreDefaultScriptDialogsEnabled(settings, TRUE);
settings->lpVtbl->put_IsWebMessageEnabled(settings, TRUE);

/* Whether dev tools are enabled or not.
* When WEBUI_LOG is defined, dev tools are enabled.
* Otherwise, dev tools are disabled. */
#ifndef WEBUI_LOG
settings->lpVtbl->put_AreDevToolsEnabled(settings, FALSE);
#endif


RECT bounds = {0, 0, webView->width, webView->height};
webView->webviewController->lpVtbl->put_Bounds(webView->webviewController, bounds);
TitleChangedHandler* titleChangedHandler = CreateTitleChangedHandler(webView);
Expand Down Expand Up @@ -11420,6 +11429,7 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpReserved) {
webView->height = (win->height > 0 ? win->height : WEBUI_DEF_HEIGHT);
webView->x = (win->x > 0 ? win->x : (int)((GetSystemMetrics(SM_CXSCREEN) - webView->width) / 2));
webView->y = (win->y > 0 ? win->y : (int)((GetSystemMetrics(SM_CYSCREEN) - webView->height) / 2));

win->webView = webView;

// Note: To garantee all Microsoft WebView's operations ownership we should
Expand Down