Skip to content

Array too small (MAX_BROWSER_FILES) #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlbertShown merged 3 commits into from
Oct 20, 2025
Merged

Array too small (MAX_BROWSER_FILES) #651

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c1b4e5
Fixed problem with array allocation for executables array.
hdijkema Oct 17, 2025
9d83d0f
Removed some NULL assignments that are not needed anymore.
hdijkema Oct 17, 2025
98c1dff
Simplify initialization of executables array
AlbertShown Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/webui.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6077,7 +6077,7 @@ static bool _webui_custom_browser_exist(_webui_window_t* win, size_t browser) {
}
}
#else
#define MAX_BROWSER_FILES (2)
#define MAX_BROWSER_FILES (5)
char* executable = NULL;
char* executables[MAX_BROWSER_FILES] = {0};
if (browser == Chrome) {
Expand All @@ -6090,7 +6090,6 @@ static bool _webui_custom_browser_exist(_webui_window_t* win, size_t browser) {
}
else if (browser == Epic) {
executables[0] = "epic";
executables[1] = NULL;
}
else if (browser == Vivaldi) {
executables[0] = "vivaldi";
Expand All @@ -6101,15 +6100,12 @@ static bool _webui_custom_browser_exist(_webui_window_t* win, size_t browser) {
executables[1] = "brave-browser-stable";
executables[2] = "brave-browser-nightly";
executables[3] = "brave-browser-beta";
executables[4] = NULL;
}
else if (browser == Firefox) {
executables[0] = "firefox";
executables[1] = NULL;
}
else if (browser == Yandex) {
executables[0] = "yandex-browser";
executables[1] = NULL;
}
else if (browser == Chromium) {
executables[0] = "chromium-browser";
Expand Down
Loading