Use pagination link for subsequent pages#20
Open
gaqzi wants to merge 1 commit intowebuildorg:masterfrom
Open
Conversation
When there are more pages of data to fetch from Meetup's API will send in the `meta` object a link to the next page. This code uses this next page to walk through all available responses instead of hoping that max pagination + 1 will be enough for the amount of groups that is available. :) This relates to issue webuildorg#19 and webuildsg/webuild#219.
Author
|
Oh, and this is a total case of "it works on my computer" as I didn't find any tests. |
Contributor
|
thanks! this is definitely a better logic - will try out this code 🤗 |
Contributor
|
Thanks @gaqzi - this is definitely the correct way. I ran the code, but meetup.com events are not being added to the total events list. I suspect some async issues. I will have a look at it to patch it. |
Author
|
booo, stupid code to not work :'( |
Contributor
|
💟 c'mon not all code that doesn't work are stupid, example this pull request 💯 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there are more pages of data to fetch from Meetup's API will
send in the
metaobject a link to the next page.This code uses this next page to walk through all available responses
instead of hoping that max pagination + 1 will be enough for the amount
of groups that is available. :)
My Javascript is… rusty. So you'll probably want to clean this up.
And I'd love to hear what could be done to make this more javascriptie. :)
This relates to issue #19 and webuildsg/webuild#219.