Skip to content

Update recaptchalib.php#1

Open
fpap wants to merge 1 commit intowecodemore:masterfrom
fpap:patch-1
Open

Update recaptchalib.php#1
fpap wants to merge 1 commit intowecodemore:masterfrom
fpap:patch-1

Conversation

@fpap
Copy link

@fpap fpap commented Jun 21, 2022

The constructor is changed from the name of the class to __construct

The constructor is changed from the name of the class to __construct
@franz-josef-kaiser
Copy link
Member

@fpap Thanks for your PR! The repo didn't change for 8 😊 years tough and I can see that we are 209 commit behind the upstream repo. Did you take a look and diff both to see if upstream fixed the issues this fork is targeting (hint: I did not yet)? Because in case, we might want to change some more things here like adding access definitions like public if we are already onto it? Opinions?

@fpap
Copy link
Author

fpap commented Jun 29, 2022

@franz-josef-kaiser no, I did not compared it... 😬 Surely they already fixed it... I agree on improving as much as possible.

@mre33
Copy link

mre33 commented Feb 14, 2023

After running into this problem with PHP 8.1, I changed the function name to ReCaptchaa and called it separately. In my main code. This needs to be changed in the library code. It doesn't pass the secret key otherwise.

Instead of calling it as:
$reCaptcha = new ReCaptcha( $secret );

Do this instead:
$reCaptcha = new ReCaptcha;
$reCaptcha->ReCaptchaa( $secret ); // had to change the name of this function in recaptchalib file to work with php 8+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants