Skip to content

feat: Added Camelcase Linters, complexity and max-params and code changes accordingly #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
himanshu-wedensday wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: Added Camelcase Linters, complexity and max-params and code changes accordingly #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module.exports = {
'key-spacing': [2, { beforeColon: false, afterColon: true }],
'arrow-parens': ['error', 'as-needed'],
'arrow-body-style': [2, 'as-needed'],

camelcase: ['error', { properties: 'always', ignoreImports: false }],
Copy link

@coderabbitai coderabbitai bot May 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

Several files in the codebase still use non-camelCase property names, which conflicts with the newly configured camelcase rule in .eslintrc.js. Here are some of the files that need attention:

  • webpack.server.config.js
  • seeders/08_users.js
  • server/utils/token.js
  • server/utils/testUtils/mockData.js
  • server/utils/tests/migrateUtils.test.js
  • server/utils/testUtils/index.js
  • seeders/06_store_products.js
  • seeders/07_purchased_products.js
  • seeders/03_stores.js
  • seeders/05_supplier_products.js
  • server/tests/index.test.js
  • server/index.js
  • server/middleware/gqlAuth/constants.js
  • server/utils/testUtils/dbConfig.js
  • server/database/models/store_products.js
  • server/database/models/suppliers.js
  • server/database/models/supplier_products.js
  • server/database/models/stores.js
  • server/database/models/purchased_products.js
  • server/database/models/products.js
  • server/database/models/index.js
  • server/database/models/addresses.js
  • server/gql/models/tests/supplierProducts/query.test.js
  • server/gql/models/tests/supplierProducts/mutation.test.js
  • server/database/models/users.js
  • server/gql/models/tests/purchasedProducts/query.test.js
  • server/gql/models/tests/purchasedProducts/mutation.test.js
  • server/gql/models/tests/products/query.test.js
  • seeders/04_supplier.js
  • server/gql/models/addresses/index.js
  • server/gql/models/aggregate/tests/purchasedProductsUtils.test.js
  • server/gql/models/aggregate/purchasedProductsUtils.js
  • server/gql/models/aggregate/tests/index.test.js
  • server/gql/models/aggregate/index.js
  • server/gql/models/tests/storeProducts/query.test.js
  • server/gql/models/tests/storeProducts/mutation.test.js

Please review and refactor these files to comply with the ESLint camelcase rule to avoid linting errors.

Analysis chain

The camelcase rule is correctly configured to enforce camelCase naming for all properties and includes checks on imports. Ensure that this change is reflected across the entire codebase to avoid linting errors.

Scripts Executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that all properties in JavaScript files adhere to camelCase naming convention.

# Test: Search for non-camelCase property names. Expect: No occurrences.
rg --type js --pcre2 '[a-z]+(_[a-z]+)+' --files-with-matches

Length of output: 1461

'class-methods-use-this': 0,
'import/imports-first': 0,
'import/newline-after-import': 0,
Expand All @@ -33,6 +33,8 @@ module.exports = {
'import/no-unresolved': 0,
'import/prefer-default-export': 0,
'no-param-reassign': 0,
'max-params': ['error', 5],
complexity: ['error', 10],
'max-len': 0,
'newline-per-chained-call': 0,
'no-confusing-arrow': 0,
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"sequelize": "^6.6.5",
"slack-notify": "^2.0.2",
"source-map-support": "^0.5.19",
"sqlite3": "^5.0.2",
"sqlite3": "^5.1.7",
"stream": "^0.0.2",
"string-replace-loader": "^3.1.0",
"subscriptions-transport-ws": "0.9.17",
Expand Down
1 change: 1 addition & 0 deletions seeders/02_addresses.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable camelcase */
module.exports = {
up: queryInterface => {
const faker = require('faker');
Expand Down
1 change: 1 addition & 0 deletions seeders/03_stores.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable camelcase */
module.exports = {
up: queryInterface => {
const faker = require('faker');
Expand Down
1 change: 1 addition & 0 deletions seeders/04_supplier.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable camelcase */
module.exports = {
up: queryInterface => {
const faker = require('faker');
Expand Down
1 change: 1 addition & 0 deletions seeders/05_supplier_products.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable camelcase */
module.exports = {
up: queryInterface => {
const range = require('lodash/range');
Expand Down
1 change: 1 addition & 0 deletions seeders/06_store_products.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable camelcase */
module.exports = {
up: queryInterface => {
const range = require('lodash/range');
Expand Down
1 change: 1 addition & 0 deletions seeders/07_purchased_products.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable camelcase */
module.exports = {
up: queryInterface => {
const faker = require('faker');
Expand Down
1 change: 1 addition & 0 deletions seeders/08_users.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable camelcase */
module.exports = {
up: queryInterface => {
const faker = require('faker');
Expand Down
2 changes: 1 addition & 1 deletion server/database/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const connect = async () => {
try {
await client.authenticate();
console.log('Connection has been established successfully.\n', {
db_uri: dbConfig.url
dbUri: dbConfig.url
});
} catch (error) {
console.error('Unable to connect to the database:', error);
Expand Down
2 changes: 1 addition & 1 deletion server/database/tests/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ describe('connect', () => {
expect(console.log.mock.calls.length).toBe(1);
expect(console.log.mock.calls[0][0]).toBe('Connection has been established successfully.\n');
expect(console.log.mock.calls[0][1]).toEqual({
db_uri: process.env.DB_URI
dbUri: process.env.DB_URI
});
});

Expand Down
1 change: 1 addition & 0 deletions server/gql/models/addresses/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable camelcase */
import { GraphQLFloat, GraphQLID, GraphQLInt, GraphQLNonNull, GraphQLObjectType, GraphQLString } from 'graphql';
import { getNode } from '@gql/node';
import { createConnection } from 'graphql-sequelize';
Expand Down
1 change: 1 addition & 0 deletions server/utils/testUtils/mockData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable camelcase */
import range from 'lodash/range';
import faker from 'faker';
import md5 from 'md5';
Expand Down
Loading