Skip to content

Conversation

@Amitjoiya
Copy link

@Amitjoiya Amitjoiya commented Nov 9, 2025

Overview

Added automatic logging of a few annotated training images before training starts.
This helps verify image–annotation alignment and improves user debugging experience.

Implementation

  • Added logic inside on_train_start() in callbacks.py
  • Logs up to 5 sample annotations using visualize.plot_annotations
  • Compatible with TensorBoard, WandB, and Comet loggers
  • Human-readable code, minimal and maintainable
  • No unrelated file formatting included

Testing

  • Verified locally with multiple datasets
  • Works with all supported loggers

@ethanwhite
Copy link
Member

Thanks for the contribution @Amitjoiya. Before we can consider the contents of the PR we need you to submit a clean PR that only includes the relevant changes, not large numbers of formatting changes across dozens of files. Once you've updated the PR accordingly let us know and we'll come back and consider the contribution.

@ethanwhite ethanwhite added the Awaiting author contribution Waiting on the issue author to do something before proceeding label Nov 10, 2025
@Amitjoiya
Copy link
Author

@ethanwhite, Thanks for the review! I’ve cleaned up the PR to include only the relevant changes for the auto-logging feature.
No formatting or unrelated modifications are present now. Please have another look when convenient 🙏

@github-actions github-actions bot removed the Awaiting author contribution Waiting on the issue author to do something before proceeding label Nov 10, 2025
@ethanwhite
Copy link
Member

I don't see any changes. Did you forget to push your updates?

@ethanwhite ethanwhite added the Awaiting author contribution Waiting on the issue author to do something before proceeding label Nov 10, 2025
@github-actions github-actions bot removed the Awaiting author contribution Waiting on the issue author to do something before proceeding label Nov 10, 2025
@Amitjoiya
Copy link
Author

@ethanwhite, Please see my PR description now that's clean and meaningful. Thanks !

@ethanwhite
Copy link
Member

Sorry for the confusion. The main issue is with the code changes themselves. If you look at https://github.com/weecology/DeepForest/pull/1203/files you'll see that 29 files have been changed and almost all of the changes are formatting changes. That makes it too time consuming to read the code changes, so each PR should only include the changes to the code necessary to implement the specific thing you're working on. Does that make sense?

@Amitjoiya
Copy link
Author

Hey @ethanwhite, Please review, Thanks !

@ethanwhite
Copy link
Member

If you look at the Files Changed tab you'll see that you have still changed the formatting on (now) 31 files. I'm guessing you have some sort of automated system that is running Ruff on the entire code base (including files that are ignored by our build system). You need to turn it off so that you can submit a clean PR.

@Amitjoiya
Copy link
Author

@ethanwhite, Please Review, Thanks !

Copy link
Contributor

@henrykironde henrykironde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Amitjoiya, for the contribution. Could you please add a screenshot showing the outcome? We’ll also need tests covering the newly added logic. I haven’t reviewed the code in depth yet, but at a glance it feels more complex than necessary. It would be good to explore simpler ways to achieve the same result, refine the implementation for clarity and only comment where necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants