Function to check internet access before network calls#1672
Open
dikwickley wants to merge 1 commit intoweecology:mainfrom
Open
Function to check internet access before network calls#1672dikwickley wants to merge 1 commit intoweecology:mainfrom
dikwickley wants to merge 1 commit intoweecology:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes: #1660
As the other PR for this issue has been stale for quite some time, this one attempts to handle the network availablity issue.
There is a utility function that terminates the program in case there is a network failure.
The function
check_network()has to be called at the top of all functions that are making a network call.In case there is a network failure, it will give this response:
Originally if there was a network failure it would throw an error.
@henrykironde If this approach looks good enough, I can proceed with adding this function everywhere.