Fix issue when ZIP64 extra field has different size than expected fro… #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m Central directory file header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…m Central directory file header
I encountered a Zip files where Central Directory header, in field diskNumberStart has value 0x0000 when it should have 0xffff for ZIP64 extension.
In this situation ZIPFoundation expect that ZIP64 Extra field will not have information about diskNumberStart and wrongly estimate the size.
Changes proposed in this PR
Checking the size of ZIP64 extra field from dataSize (data.scanValue(start: 2)), not from fields in CD header which have 0xffff