fix(mitthooks-drizzle): persist variantKey on update and upsert#68
Open
jankal wants to merge 1 commit intoweissaufschwarz:mainfrom
Open
fix(mitthooks-drizzle): persist variantKey on update and upsert#68jankal wants to merge 1 commit intoweissaufschwarz:mainfrom
jankal wants to merge 1 commit intoweissaufschwarz:mainfrom
Conversation
…ertExtension PgExtensionStorage.updateExtension() does not include variantKey in its SET clause, so InstanceUpdated webhooks silently drop the new variant. The same field is also missing from upsertExtension()'s INSERT values and ON CONFLICT UPDATE set. Add variantKey to all three locations so it is persisted correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
variantKeyto theSETclause inPgExtensionStorage.updateExtension()variantKeyto.values()and.onConflictDoUpdate().set()inPgExtensionStorage.upsertExtension()Without this fix,
InstanceUpdatedwebhooks from mittwald do not persist the newvariantKeyto the database, even though the column exists in the schema and the type includes the field.Test plan
InstanceUpdatedwebhook and verifyvariant_keycolumn is updated in the DBInstanceAddedwebhook and verifyvariant_keyis set on initial insertInstanceAddedwebhook for an existing instance (upsert path) and verifyvariant_keyis updated🤖 Generated with Claude Code