Passing ftp connection params in extended format#20
Open
mukkoo wants to merge 1 commit intowelaika:masterfrom
Open
Passing ftp connection params in extended format#20mukkoo wants to merge 1 commit intowelaika:masterfrom
mukkoo wants to merge 1 commit intowelaika:masterfrom
Conversation
Member
alessandro-fazzi
left a comment
There was a problem hiding this comment.
Generally approve, but a question - not born from your code -: why are we URL-encoding the password instead of using Shellwords.escape? Isn't that string constructed to be a system call?
Author
|
Nice question. I think that |
Member
|
We should plan make a Wordmove's release with the updated dependency |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #19 and related welaika/wordmove#320