Skip to content

Passing ftp connection params in extended format#20

Open
mukkoo wants to merge 1 commit intowelaika:masterfrom
mukkoo:ftp_params
Open

Passing ftp connection params in extended format#20
mukkoo wants to merge 1 commit intowelaika:masterfrom
mukkoo:ftp_params

Conversation

@mukkoo
Copy link

@mukkoo mukkoo commented Apr 17, 2018

Fix for #19 and related welaika/wordmove#320

@mukkoo mukkoo requested a review from alessandro-fazzi April 17, 2018 08:22
Copy link
Member

@alessandro-fazzi alessandro-fazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally approve, but a question - not born from your code -: why are we URL-encoding the password instead of using Shellwords.escape? Isn't that string constructed to be a system call?

@mukkoo
Copy link
Author

mukkoo commented Apr 17, 2018

Nice question. I think that CGI.escape is an old (unquoted) implementation.
Since version 1.0.0.pre has been introduced Shellwords.
In this specific case can be easier to leave CGI.escape because command in into a quoted context

lftp -c 'set ftp:list-options -a; set cmd:fail-exit true; open --user user --password password --parallel=5 --reverse --dereference --exclude-glob .git --exclude-glob *.sql --exclude-glob bin/'

Copy link
Member

@alessandro-fazzi alessandro-fazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alessandro-fazzi
Copy link
Member

We should plan make a Wordmove's release with the updated dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants