Skip to content

[CFE-840] - refactor: Updates the modal component to use the UnnnicDialog #1100

Open
Aldemylla wants to merge 6 commits intorefactor/migrate-billing-intern-modalfrom
refactor/migrate-intern-modal
Open

[CFE-840] - refactor: Updates the modal component to use the UnnnicDialog #1100
Aldemylla wants to merge 6 commits intorefactor/migrate-billing-intern-modalfrom
refactor/migrate-intern-modal

Conversation

@Aldemylla
Copy link
Collaborator

@Aldemylla Aldemylla commented Feb 12, 2026

CFE-840## Description

Type of Change

  • Refactoring (no functional changes, no api changes)

Motivation and Context

This change updates the modal component to use the UnnnicDialog component from the design system, providing a more consistent UI experience across the application.

Summary of Changes

  • Replaced custom modal implementation with UnnnicDialog component
  • Removed explicit icon properties from modal calls as they are now handled by the dialog component based on the scheme type
  • Updated dialog type mapping to use appropriate feedback types (warning, attention, success)
  • Fixed the leave organization description to include the organization name in all language files
  • Simplified button type handling for modals
  • Removed unused methods like openServerErrorAlertModal and showDeleteConfirmation

Description

This PR refactors the Modal component to leverage the UnnnicDialog component from our design system. The change maintains all existing functionality while providing a more consistent look and feel with the rest of the application. The refactoring removes redundant icon specifications since the dialog component now determines the appropriate icon based on the scheme type.

… remove unused icon properties from modal data across multiple components for improved consistency
…on name and remove unused alert modal methods for improved clarity and maintainability
@Aldemylla Aldemylla changed the title [] - refactor: simplify button type handling and remove unused styles in Modal.vue for improved clarity [CFE-840] - refactor: simplify button type handling and remove unused styles in Modal.vue for improved clarity Feb 12, 2026
@Aldemylla Aldemylla changed the title [CFE-840] - refactor: simplify button type handling and remove unused styles in Modal.vue for improved clarity Replace modal icons with UnnnicDialog component Feb 12, 2026
@Aldemylla Aldemylla changed the title Replace modal icons with UnnnicDialog component [CFE-840] - refactor: Updates the modal component to use the UnnnicDialog Feb 12, 2026
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 63.49206% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.38%. Comparing base (b3876c2) to head (cf6b7bd).

Files with missing lines Patch % Lines
src/components/external/Modal.vue 61.66% 23 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                            @@
##           refactor/migrate-billing-intern-modal    #1100      +/-   ##
=========================================================================
+ Coverage                                  50.18%   50.38%   +0.20%     
=========================================================================
  Files                                        180      180              
  Lines                                      20492    20387     -105     
  Branches                                     668      668              
=========================================================================
- Hits                                       10283    10272      -11     
+ Misses                                     10209    10115      -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Aldemylla Aldemylla marked this pull request as ready for review March 6, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants