Skip to content

Conversation

@djhvscf
Copy link
Collaborator

@djhvscf djhvscf commented Nov 16, 2025

🤔Type of Request

  • Bug fix
  • New feature
  • Improvement
  • Documentation
  • Other

🔗Resolves an issue?
Fix #7287

📝Changelog

  • Core
  • Extensions

💡Example(s)?
https://live.bootstrap-table.com/code/djhvscf/19087

☑️Self Check before Merge

⚠️ Please check all items below before reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@djhvscf djhvscf requested a review from wenzhixin November 16, 2025 05:15
@wenzhixin wenzhixin requested a review from Copilot November 16, 2025 05:29
Copilot finished reviewing on behalf of wenzhixin November 16, 2025 05:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #7287 by preventing the page number from being reset to 1 during initial table rendering when filter controls are being initialized. The fix aligns the filter-control extension's behavior with the core search module's handling of initial search text.

Key Changes:

  • Introduces an isInitialRender flag based on the _initialized state to detect when the table is still initializing
  • Conditionally resets pageNumber to 1 only when not during initial render and cookies are disabled
  • Passes firedByInitSearchText parameter to onSearch() method to maintain consistency with core search module behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@djhvscf djhvscf requested a review from Copilot November 16, 2025 05:36
Copilot finished reviewing on behalf of djhvscf November 16, 2025 05:38
@wenzhixin
Copy link
Owner

The refs issue cannot be fixed. After jumping to page 2 and running it, it still displays page 1.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@djhvscf
Copy link
Collaborator Author

djhvscf commented Nov 21, 2025

@wenzhixin for me is working as expected:

7287.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filtercontroll overwrites the pageNumber

3 participants