-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Fix issue #7287 #8078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Fix issue #7287 #8078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes issue #7287 by preventing the page number from being reset to 1 during initial table rendering when filter controls are being initialized. The fix aligns the filter-control extension's behavior with the core search module's handling of initial search text.
Key Changes:
- Introduces an
isInitialRenderflag based on the_initializedstate to detect when the table is still initializing - Conditionally resets
pageNumberto 1 only when not during initial render and cookies are disabled - Passes
firedByInitSearchTextparameter toonSearch()method to maintain consistency with core search module behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The refs issue cannot be fixed. After jumping to page 2 and running it, it still displays page 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@wenzhixin for me is working as expected: 7287.mp4 |
🤔Type of Request
🔗Resolves an issue?
Fix #7287
📝Changelog
💡Example(s)?
https://live.bootstrap-table.com/code/djhvscf/19087
☑️Self Check before Merge