Implement simple iteration support #1170
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add FlatType rule type (value 4) for @-prefixed domains - Treat both domain and subdomains as independent registrable domains - Example: @nhs.uk makes nhs.uk AND foo.nhs.uk both registrable - Update NewRule() to parse @ prefix - Update Decompose() with FlatType case logic - Fix ineffective break statements (use continue instead) - Update module name to github.com/nerdlem/publicsuffix-go - Add comprehensive flat rules documentation to README - All tests passing
- Change Decompose() for FlatType to return (full_domain, "")
- For @nhs.uk: nhs.uk -> ("nhs.uk", ""), foo.nhs.uk -> ("foo.nhs.uk", "")
- Add special handling in ParseFromListWithOptions for flat rules
- Flat rules now correctly return DomainName with TLD="" and SLD=full_domain
- This makes each domain independent without hierarchical suffix handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides support for a simple
.Iterate(f)mechanism allowing for restricted introspection into a loaded List. This drives a use case where the PSL is being used to proactively navigate the DNS namespace looking for non-obvious apexes.