Skip to content

Ensure that rows.Close is called#28

Closed
hughdbrown wants to merge 1 commit intowesm:mainfrom
hughdbrown:bug-missing-defer-rows-close
Closed

Ensure that rows.Close is called#28
hughdbrown wants to merge 1 commit intowesm:mainfrom
hughdbrown:bug-missing-defer-rows-close

Conversation

@hughdbrown
Copy link
Copy Markdown
Contributor

This blocks a resource leak.

@wesm
Copy link
Copy Markdown
Owner

wesm commented Feb 3, 2026

This was superseded by the refactoring PR that I just landed (see https://github.com/wesm/msgvault/blob/main/internal/store/store.go#L133 rows.Close is called there), but thank you for catching this! keep the fixes coming

@wesm wesm closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants