Skip to content

Commit f54dd84

Browse files
committed
Merge branch 'feature/jaino/#289' into develop
2 parents 155b0b4 + 4e96888 commit f54dd84

File tree

12 files changed

+1
-128
lines changed

12 files changed

+1
-128
lines changed

app/src/main/kotlin/com/bff/wespot/main/viewmodel/MainViewModel.kt

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ package com.bff.wespot.main.viewmodel
22

33
import androidx.lifecycle.ViewModel
44
import androidx.lifecycle.viewModelScope
5-
import com.bff.wespot.analytic.AnalyticsEvent
6-
import com.bff.wespot.analytic.AnalyticsHelper
75
import com.bff.wespot.common.util.AppVersionUtils.VersionCompareResult
86
import com.bff.wespot.common.util.AppVersionUtils.versionCompare
97
import com.bff.wespot.domain.repository.CommonRepository
@@ -37,7 +35,6 @@ class MainViewModel @Inject constructor(
3735
private val dataStoreRepository: DataStoreRepository,
3836
private val userRepository: UserRepository,
3937
private val coroutineDispatcher: CoroutineDispatcher,
40-
private val analyticsHelper: AnalyticsHelper,
4138
private val commonRepository: CommonRepository,
4239
private val remoteConfigRepository: RemoteConfigRepository,
4340
) : ViewModel(),
@@ -153,21 +150,9 @@ class MainViewModel @Inject constructor(
153150
}
154151

155152
private fun handleEnteredFromPushNotification(data: PushNotificationData) = intent {
156-
trackPushNotificationClicked(data)
157153
postSideEffect(MainSideEffect.NavigateFromPushNotification(data))
158154
}
159155

160-
private fun trackPushNotificationClicked(data: PushNotificationData) {
161-
analyticsHelper.logEvent(
162-
event = AnalyticsEvent(
163-
type = "push_notification_clicked",
164-
extras = listOf(
165-
AnalyticsEvent.Param("type", data.type.name),
166-
),
167-
),
168-
)
169-
}
170-
171156
private fun handleOnBoardingClose(category: OnBoardingCategory) = intent {
172157
when (category) {
173158
OnBoardingCategory.VOTE -> reduce { state.copy(showVoteOnBoarding = false) }

app/src/main/kotlin/com/bff/wespot/notification/PushNotificationService.kt

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ import android.media.RingtoneManager
88
import androidx.core.app.NotificationCompat
99
import androidx.core.content.ContextCompat
1010
import com.bff.wespot.R
11-
import com.bff.wespot.analytic.AnalyticsEvent
12-
import com.bff.wespot.analytic.AnalyticsHelper
1311
import com.bff.wespot.common.CHANNEL_ID
1412
import com.bff.wespot.domain.repository.DataStoreRepository
1513
import com.bff.wespot.domain.util.DataStoreKey.PUSH_TOKEN
@@ -33,9 +31,6 @@ class PushNotificationService : FirebaseMessagingService() {
3331
lateinit var coroutineDispatcher: CoroutineDispatcher
3432
private val coroutineScope by lazy { CoroutineScope(coroutineDispatcher) }
3533

36-
@Inject
37-
lateinit var analyticsHelper: AnalyticsHelper
38-
3934
override fun onNewToken(token: String) {
4035
super.onNewToken(token)
4136
coroutineScope.launch {
@@ -47,7 +42,6 @@ class PushNotificationService : FirebaseMessagingService() {
4742
super.onMessageReceived(message)
4843
if (message.data.isNotEmpty() || message.notification != null) {
4944
sendNotification(message)
50-
trackPushNotification(message)
5145
}
5246
}
5347

@@ -92,19 +86,6 @@ class PushNotificationService : FirebaseMessagingService() {
9286
notificationManager.notify(notificationId, notificationBuilder.build())
9387
}
9488

95-
private fun trackPushNotification(message: RemoteMessage) {
96-
val paramList = message.data.map { (key, value) ->
97-
AnalyticsEvent.Param(key, value.toString())
98-
}
99-
100-
analyticsHelper.logEvent(
101-
AnalyticsEvent(
102-
type = "push_notification_received",
103-
extras = paramList,
104-
),
105-
)
106-
}
107-
10889
override fun onDestroy() {
10990
super.onDestroy()
11091
coroutineScope.cancel()

feature/auth/src/main/kotlin/com/bff/wespot/auth/screen/ClassScreen.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import androidx.compose.ui.platform.LocalSoftwareKeyboardController
2222
import androidx.compose.ui.res.stringResource
2323
import androidx.compose.ui.text.input.KeyboardType
2424
import androidx.compose.ui.unit.dp
25-
import com.bff.wespot.analytic.TrackScreenViewEvent
2625
import com.bff.wespot.auth.R
2726
import com.bff.wespot.auth.state.AuthAction
2827
import com.bff.wespot.auth.state.NavigationAction
@@ -142,6 +141,4 @@ fun ClassScreen(
142141
delay(10)
143142
keyboard?.show()
144143
}
145-
146-
TrackScreenViewEvent(screenName = "class_screen", id = state.uuid)
147144
}

feature/auth/src/main/kotlin/com/bff/wespot/auth/screen/CompleteScreen.kt

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ import androidx.compose.ui.res.painterResource
2222
import androidx.compose.ui.res.stringResource
2323
import androidx.compose.ui.unit.dp
2424
import androidx.lifecycle.compose.collectAsStateWithLifecycle
25-
import com.bff.wespot.analytic.AnalyticsEvent
26-
import com.bff.wespot.analytic.AnalyticsEvent.Param
27-
import com.bff.wespot.analytic.LocalAnalyticsHelper
28-
import com.bff.wespot.analytic.TrackScreenViewEvent
2925
import com.bff.wespot.auth.R
3026
import com.bff.wespot.auth.state.AuthAction
3127
import com.bff.wespot.auth.viewmodel.AuthViewModel
@@ -52,13 +48,8 @@ fun CompleteScreen(
5248

5349
val activity = LocalActivity.current
5450
val context = LocalContext.current
55-
var inviteClicked by remember {
56-
mutableStateOf(false)
57-
}
5851
val networkState by viewModel.networkState.collectAsStateWithLifecycle()
5952

60-
val analyticsHelper = LocalAnalyticsHelper.current
61-
6253
val message = context.getString(com.bff.wespot.designsystem.R.string.invite_message)
6354

6455
handleSideEffect(viewModel.sideEffect)
@@ -85,7 +76,6 @@ fun CompleteScreen(
8576
context,
8677
message + state.playStoreLink,
8778
)
88-
inviteClicked = true
8979
},
9080
text = stringResource(id = R.string.invite_friend_and_start),
9181
paddingValues = PaddingValues(horizontal = 20.dp, vertical = 8.dp),
@@ -95,15 +85,6 @@ fun CompleteScreen(
9585

9686
WSOutlineButton(
9787
onClick = {
98-
analyticsHelper.logEvent(
99-
AnalyticsEvent(
100-
type = "invite_friend_before_sign_up",
101-
extras = listOf(
102-
Param("screen_name", "complete_sign_up"),
103-
Param("invite_clicked", inviteClicked.toString()),
104-
),
105-
),
106-
)
10788
viewModel.onAction(AuthAction.Signup)
10889
},
10990
text = stringResource(id = R.string.start),
@@ -137,6 +118,4 @@ fun CompleteScreen(
137118
}
138119

139120
NetworkDialog(context = context, networkState = networkState)
140-
141-
TrackScreenViewEvent(screenName = "complete_screen", id = state.uuid)
142121
}

feature/auth/src/main/kotlin/com/bff/wespot/auth/screen/EditScreen.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ import coil3.compose.AsyncImage
3737
import coil3.request.ImageRequest
3838
import coil3.request.error
3939
import coil3.request.placeholder
40-
import com.bff.wespot.analytic.TrackScreenViewEvent
4140
import com.bff.wespot.auth.R
4241
import com.bff.wespot.auth.state.AuthAction
4342
import com.bff.wespot.auth.state.AuthUiState
@@ -167,8 +166,6 @@ fun EditScreen(
167166
}
168167
}
169168
}
170-
171-
TrackScreenViewEvent(screenName = "edit_screen", id = state.uuid)
172169
}
173170

174171
@Composable

feature/auth/src/main/kotlin/com/bff/wespot/auth/screen/GenderScreen.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import androidx.compose.ui.graphics.painter.Painter
2626
import androidx.compose.ui.res.painterResource
2727
import androidx.compose.ui.res.stringResource
2828
import androidx.compose.ui.unit.dp
29-
import com.bff.wespot.analytic.TrackScreenViewEvent
3029
import com.bff.wespot.auth.R
3130
import com.bff.wespot.auth.state.AuthAction
3231
import com.bff.wespot.auth.state.NavigationAction
@@ -110,7 +109,6 @@ fun GenderScreen(
110109
}
111110
}
112111
}
113-
TrackScreenViewEvent(screenName = "gender_screen", id = state.uuid)
114112
}
115113

116114
@Composable

feature/auth/src/main/kotlin/com/bff/wespot/auth/screen/GradeScreen.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import androidx.compose.ui.graphics.Color
2424
import androidx.compose.ui.res.painterResource
2525
import androidx.compose.ui.res.stringResource
2626
import androidx.compose.ui.unit.dp
27-
import com.bff.wespot.analytic.TrackScreenViewEvent
2827
import com.bff.wespot.auth.R
2928
import com.bff.wespot.auth.state.AuthAction
3029
import com.bff.wespot.auth.state.NavigationAction
@@ -168,7 +167,6 @@ fun GradeScreen(
168167
}
169168
}
170169
}
171-
TrackScreenViewEvent(screenName = "grade_screen", id = state.uuid)
172170
}
173171

174172
@Composable

feature/auth/src/main/kotlin/com/bff/wespot/auth/screen/NameScreen.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import androidx.compose.ui.platform.LocalSoftwareKeyboardController
2525
import androidx.compose.ui.res.stringResource
2626
import androidx.compose.ui.unit.dp
2727
import androidx.lifecycle.compose.collectAsStateWithLifecycle
28-
import com.bff.wespot.analytic.TrackScreenViewEvent
2928
import com.bff.wespot.auth.R
3029
import com.bff.wespot.auth.state.AuthAction
3130
import com.bff.wespot.auth.state.NavigationAction
@@ -171,6 +170,4 @@ fun NameScreen(
171170
LaunchedEffect(Unit) {
172171
action(AuthAction.OnStartNameScreen)
173172
}
174-
175-
TrackScreenViewEvent(screenName = "name_screen", id = state.uuid)
176173
}

feature/auth/src/main/kotlin/com/bff/wespot/auth/screen/SchoolScreen.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ import androidx.lifecycle.compose.collectAsStateWithLifecycle
3131
import androidx.paging.LoadState
3232
import androidx.paging.compose.collectAsLazyPagingItems
3333
import androidx.paging.compose.itemKey
34-
import com.bff.wespot.analytic.TrackScreenViewEvent
3534
import com.bff.wespot.auth.R
3635
import com.bff.wespot.auth.state.AuthAction
3736
import com.bff.wespot.auth.state.NavigationAction
@@ -232,6 +231,4 @@ fun SchoolScreen(
232231
LaunchedEffect(Unit) {
233232
action(AuthAction.OnStartSchoolScreen)
234233
}
235-
236-
TrackScreenViewEvent(screenName = "school_screen", id = state.uuid)
237234
}

feature/message/src/main/kotlin/com/bff/wespot/message/viewmodel/SendViewModel.kt

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ package com.bff.wespot.message.viewmodel
22

33
import androidx.lifecycle.viewModelScope
44
import androidx.paging.cachedIn
5-
import com.bff.wespot.analytic.AnalyticsEvent
6-
import com.bff.wespot.analytic.AnalyticsHelper
75
import com.bff.wespot.common.extension.onNetworkFailure
86
import com.bff.wespot.designsystem.component.indicator.WSToastType
97
import com.bff.wespot.domain.repository.BasePagingRepository
@@ -44,9 +42,6 @@ import org.orbitmvi.orbit.syntax.simple.postSideEffect
4442
import org.orbitmvi.orbit.syntax.simple.reduce
4543
import org.orbitmvi.orbit.viewmodel.container
4644
import timber.log.Timber
47-
import java.time.LocalDateTime
48-
import java.time.ZoneId
49-
import java.time.format.DateTimeFormatter
5045
import javax.inject.Inject
5146

5247
@HiltViewModel
@@ -56,7 +51,6 @@ class SendViewModel @Inject constructor(
5651
private val commonRepository: CommonRepository,
5752
private val userListRepository: BasePagingRepository<User, Paging<User>>,
5853
private val checkProfanityUseCase: CheckProfanityUseCase,
59-
private val analyticsHelper: AnalyticsHelper,
6054
) : BaseViewModel(),
6155
ContainerHost<MessageSendUiState, MessageSendSideEffect> {
6256
override val container = container<MessageSendUiState, MessageSendSideEffect>(MessageSendUiState())
@@ -437,7 +431,6 @@ class SendViewModel @Inject constructor(
437431
anonymousProfileName = state.senderProfile.name,
438432
),
439433
).onSuccess {
440-
trackMessageSendEvent()
441434
reduce { state.copy(isLoading = false) }
442435
postSideEffect(SendSideEffect.ShowToast(R.string.message_send_success))
443436
postSideEffect(SendSideEffect.NavigateToMessage)
@@ -457,21 +450,6 @@ class SendViewModel @Inject constructor(
457450
uploadResult.getOrThrow()
458451
}
459452

460-
private fun trackMessageSendEvent() = intent {
461-
val formatter = DateTimeFormatter.ISO_LOCAL_DATE_TIME
462-
val sendTime = LocalDateTime.now(ZoneId.of("Asia/Seoul")).format(formatter)
463-
464-
analyticsHelper.logEvent(
465-
event = AnalyticsEvent(
466-
type = "message_send",
467-
extras = listOf(
468-
AnalyticsEvent.Param("userId", state.profile.id.toString()),
469-
AnalyticsEvent.Param("time", sendTime),
470-
),
471-
),
472-
)
473-
}
474-
475453
fun clearUiState() = intent {
476454
reduce {
477455
MessageSendUiState()

0 commit comments

Comments
 (0)