Skip to content

fix(friend course):improve errorResponse Message #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renbaoshuo merged 1 commit into from
Mar 7, 2026
Merged

fix(friend course):improve errorResponse Message #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/course/service/get_friend_course.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ func (s *CourseService) GetFriendCourse(req *course.GetFriendCourseRequest, logi
return nil, fmt.Errorf("service.GetSemesterCourses: Get courses fail: %w", err)
}
if courses == nil {
return nil, errno.NewErrNo(errno.InternalServiceErrorCode, "service.GetSemesterCourses: there is no course in database, please login app and retry")
return nil, fmt.Errorf("暂无好友课表信息，快通知好友登录App刷新课表吧")
}
list := make([]*kitexModel.Course, 0)
if courses.TermCourses != "" {
Expand Down
2 changes: 1 addition & 1 deletion internal/course/service/get_friend_course_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ func TestGetFriendCourse(t *testing.T) {
termsDB: &dbmodel.UserTerm{TermTime: pack.BuildTermOnDB([]string{"202401"})},
dbCourse: (*dbmodel.UserCourse)(nil),
reqTerm: "202401",
expectErr: "there is no course in database",
expectErr: "暂无好友课表信息，快通知好友登录App刷新课表吧",
},
{
name: "db course unmarshal error",
Expand Down