Use a u32 for MCTPTransportHeader storage#10
Draft
mkj wants to merge 1 commit intowesterndigitalcorporation:masterfrom
Draft
Use a u32 for MCTPTransportHeader storage#10mkj wants to merge 1 commit intowesterndigitalcorporation:masterfrom
mkj wants to merge 1 commit intowesterndigitalcorporation:masterfrom
Conversation
This compiles to much more efficient code in the bitfield operations.
Collaborator
|
I'm fine with the change. Saving code size is great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves ~800 bytes of code size from a current project (cortex M7, opt "s" or "z"), and uses a lot fewer cycles.
I'm pushing this as a draft PR, if you like the approach I could change the other bitfields similarly.
This does change the API a bit, instead of
hdr.0you usehdr.to_bytes(), and theMCTPTransportHeaderno longer has the type parameterMCTPTransportHeader<[u8; 4]>.This compiles to much more efficient code in the bitfield operations.
The code I'm testing with is fairly simple, setting a few headers similar to: