Skip to content

fs: rebuild zone lifetime while mount #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ywang-wnlo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fs: rebuild zone lifetime while mount #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions fs/fs_zenfs.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,19 @@ IOStatus ZenFS::Repair() {
return IOStatus::OK();
}

void ZenFS::RebuildZoneLifeTime() {
std::map<std::string, std::shared_ptr<ZoneFile>>::iterator it;
for (it = files_.begin(); it != files_.end(); it++) {
std::shared_ptr<ZoneFile> zFile = it->second;
std::vector<ZoneExtent*> extents = zFile->GetExtents();
Env::WriteLifeTimeHint file_lifetime = zFile->GetWriteLifeTimeHint();
for (const auto* ext : extents) {
Zone* zone = ext->zone_;
if (zone->lifetime_ < file_lifetime) zone->lifetime_ = file_lifetime;
}
}
}

std::string ZenFS::FormatPathLexically(fs::path filepath) {
fs::path ret = fs::path("/") / filepath.lexically_normal();
return ret.string();
Expand Down Expand Up @@ -1471,6 +1484,8 @@ Status ZenFS::Mount(bool readonly) {
}
}

RebuildZoneLifeTime();

Info(logger_, "Superblock sequence %d", (int)superblock_->GetSeq());
Info(logger_, "Finish threshold %u", superblock_->GetFinishTreshold());
Info(logger_, "Filesystem mount OK");
Expand Down
2 changes: 2 additions & 0 deletions fs/fs_zenfs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,8 @@ class ZenFS : public FileSystemWrapper {

IOStatus Repair();

void RebuildZoneLifeTime();

/* Must hold files_mtx_ */
IOStatus DeleteDirRecursiveNoLock(const std::string& d,
const IOOptions& options,
Expand Down