-
Notifications
You must be signed in to change notification settings - Fork 1
bump template to v2024.29 #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6b74216
bump template to v2024.29
joshuadavidthomas 95e8f8c
revert changes to changelog
joshuadavidthomas 4938ff7
reset a bunch of files
joshuadavidthomas 625dcce
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] bafab3c
more reverts
joshuadavidthomas ad657fc
add back demo
joshuadavidthomas 8f2b9b2
more reverts
joshuadavidthomas 4177670
revertttt
joshuadavidthomas 02504f4
update link
joshuadavidthomas 596b71b
revert basedpyright config
joshuadavidthomas 608e0aa
regenerate lock and fix nox call
joshuadavidthomas b8dbe8b
update changelog
joshuadavidthomas 7b8a570
revert drop of 3.8
joshuadavidthomas 8507278
revert revert drop of 3.8
joshuadavidthomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| # Authors | ||
|
|
||
| - Josh Thomas <[email protected]> | ||
| - Jeff Triplett [@jefftriplett](https://github.com/jefftriplett) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you have second thoughts on dumping 3.8? (I think it can be a soft drop where we don't go out of our way to prevent it working on 3.8)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm not going out of my way to prevent it working, but I'm publicly dropping support the minute a version goes on this list: https://devguide.python.org/versions/#unsupported-versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though now that I think through it, maybe Django should be the driver of that -- and 3.8 is still supported under 4.2 https://docs.djangoproject.com/en/dev/faq/install/#what-python-version-can-i-use-with-django.
I could go either way I guess, not sure what the right decision is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I'm going to leave it alone for now and stick to if Django supports it, we'll support it as long as we aren't using a feature of Python not available in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh... I see what you were asking now 🤦♂️
No, the copier update wiped away the README and I reverted it to the one on
mainand missed that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EH, in light of that, dropping 3.8 seems fine.. What a wild ride.