Skip to content

Ignore missing URL parts in NavItem activity check #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025
Merged

Ignore missing URL parts in NavItem activity check #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54aa64c
Ignore missing URL parts in NavItem activity check
HiPhish Apr 15, 2025
a8bf324
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/django_simple_nav/nav.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,8 @@ def get_active(self, request: HttpRequest) -> bool:
parsed_url = urlparse(url)
parsed_request = urlparse(request.build_absolute_uri())

if (
parsed_url.scheme != parsed_request.scheme
or parsed_url.netloc != parsed_request.netloc
if (parsed_url.scheme and (parsed_url.scheme != parsed_request.scheme)) or (
parsed_url.netloc and (parsed_url.netloc != parsed_request.netloc)
):
return False

Expand Down
8 changes: 8 additions & 0 deletions tests/test_navitem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,14 @@ def test_active_different_domain(rf):
assert item.get_active(req) is False


def test_active_no_scheme_no_netloc(rf):
item = NavItem(title=..., url="/test/")

req = rf.get("/test")

assert item.get_active(req) is True


@pytest.mark.parametrize("append_slash", [True, False])
def test_active_append_slash_setting(append_slash, rf):
item = NavItem(title=..., url="http://testserver/test")
Expand Down