Skip to content

Short-circuit in NavGroup.get_active #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

Short-circuit in NavGroup.get_active #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/django_simple_nav/nav.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,12 +240,10 @@ def get_url(self) -> str:

@override
def get_active(self, request: HttpRequest) -> bool:
is_active = super().get_active(request)

if super().get_active(request):
return True
items = self.get_items(request)
item_is_active = any([item.get_active(request) for item in items])

return is_active or item_is_active
return any(item.get_active(request) for item in items)

@override
def check_permissions(self, request: HttpRequest) -> bool:
Expand Down