WCAG upgrade: Create working example for: Scaffolding - Typography#2236
Open
BrahimMahadi wants to merge 5 commits intowet-boew:masterfrom
Open
WCAG upgrade: Create working example for: Scaffolding - Typography#2236BrahimMahadi wants to merge 5 commits intowet-boew:masterfrom
BrahimMahadi wants to merge 5 commits intowet-boew:masterfrom
Conversation
duboisp
requested changes
Mar 6, 2024
Member
|
@BrahimMahadi Please also fix the merge conflict. Thanks |
duboisp
requested changes
Mar 12, 2024
Member
duboisp
left a comment
duboisp
left a comment
There was a problem hiding this comment.
Review and tested locally, Everything work as expected except the 2 changes to do in both language.
- remove the breadcrumb
- Fix the broken link and use relative link instead.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created working example for testing with filled text (like “Lorem ipsum”) for: Scaffolding - Typography