Skip to content

Contributors: move to sites, change context of use#2459

Merged
Garneauma merged 2 commits intowet-boew:masterfrom
Garneauma:gc-contributors
Feb 20, 2025
Merged

Contributors: move to sites, change context of use#2459
Garneauma merged 2 commits intowet-boew:masterfrom
Garneauma:gc-contributors

Conversation

@Garneauma
Copy link
Copy Markdown
Collaborator

  • Moved Cotnributors component to Sites section
  • Updated Page details component to include Contributors component
  • Updated Topic template with new Contributors location

Related to WET-505

@Garneauma
Copy link
Copy Markdown
Collaborator Author

Pre-approved upon successful review.

Copy link
Copy Markdown
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo:

  • Centralize sample inside the contributor component.
  • (Optional) remove the "gc-" prefix in the file/folder name for the contributor component
  • Update the contributor component documentation to add more emphasis on the breaking change + migration instruction.
  • Page details - move demoted pattern in demoted folder
  • For "contributor" component, make it a minor version for now (v1.1) because both are still ok, but identify the version 1.0 as demoted. We will increase the major version when we will switch the v1.0 from "demoted" into "deprecated" state.

This change is:

  • Minor change for contributor component - Add new pattern where located in the page details section
  • Minor change for page details component - Add new pattern that include the contributor component
  • Minor change for Topic template - Add new pattern that include the new page details with the contributor component
  • Minor change for the "Topic" template - Add new pattern that implement page-details v 3.3 where the contributor component are in the page-details section
  • We will perform a major change to those component, when we will switch them from "demoted" into "deprecated" at our next major release

Copy link
Copy Markdown
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed and tested locally all modified files. Its look good. There is a few inline comment to address and the following change to do:

Can you add a temporary redirect for the following files? This is to avoid broken link from the guidance material. Add a comment that those redirect can be removed in a year or two from now.

  • /components/gc-contributors/gc-contributors-doc-en.html
  • /components/gc-contributors/gc-contributors-doc-fr.html
  • /components/gc-contributors/gc-contributors-en.html
  • /components/gc-contributors/gc-contributors-fr.html

Once that completed, I will be able to approve this PR.

Note: This PR does impact:

  • Minor - Contributor
  • Minor - Page details
  • Minor - Topic template

duboisp
duboisp previously approved these changes Feb 19, 2025
Copy link
Copy Markdown
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and looks good.

Copy link
Copy Markdown
Member

@duboisp duboisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me and @Garneauma reviewed the change required to fix the merge conflict, the merged conflict are resolved and should work as expected

@Garneauma Garneauma added this to the v16.3.0 milestone Feb 19, 2025
@Garneauma Garneauma merged commit 9313405 into wet-boew:master Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants