Skip to content

Thematic: Retirement life event#2691

Draft
EricDunsworth wants to merge 1 commit intowet-boew:masterfrom
EricDunsworth:thematic-retirement-life-event
Draft

Thematic: Retirement life event#2691
EricDunsworth wants to merge 1 commit intowet-boew:masterfrom
EricDunsworth:thematic-retirement-life-event

Conversation

@EricDunsworth
Copy link
Copy Markdown
Member

@EricDunsworth EricDunsworth commented Nov 21, 2025

  • Extremely preliminary
  • Barely a thematic at this point (more like sloppy custom CSS than a thematic atm)
  • Checklist has custom JS that hasn't made its way into this PR yet
  • Needs way more work

CC @fsnoddy @Ricokola

@EricDunsworth
Thematic: Retirement life event
8119c73 
* Extremely preliminary
* Barely a thematic at this point (more like sloppy custom CSS than a thematic atm)
* Checklist has custom JS that hasn't made its way into this PR yet
* Needs way more work
@duboisp
Copy link
Copy Markdown
Member

duboisp commented Nov 29, 2025

Now that the life event has growth and it seems there to last, I recommend to move all that code into an independent project, like the search-ui. There is a few condition, which PP will be able to share to you via email, but it looks like same condition as a thématique minus the progressive enhancement which become a recommendation. And plus the requirement to manage that single repository as an enterprise repository. We will do the check once the tag is created and ready for deployment or on a pull request when requested (which still require a check prior to initiate the deployment). That will also require to perform at minimum 2 release+deployment per year to keep the project in an actif state.

The easiest way to start that process will be to submit a service desk request to PP and we will meet with you and your team about it.

Cheers

@EricDunsworth
Copy link
Copy Markdown
Member Author

EricDunsworth commented Feb 2, 2026

Just as a follow-up to @duboisp's comment... a ServiceCanada/canada-life-events repo was recently created.

It'll initially serve as the home for the Retirement life event thematic and eventually become the "go-to" repo for all life events.

EricDunsworth added a commit to EricDunsworth/canada-life-events that referenced this pull request Mar 6, 2026
@EricDunsworth
Repo: Port draft retirement life event thematic
ffd6246 
Port of wet-boew/GCWeb#2691 (Thematic: Retirement life event):
* Extremely preliminary
* Barely a thematic at this point (more like sloppy custom CSS than a thematic atm)
* Checklist has custom JS that hasn't made its way into this PR yet
* Needs way more work

Changes to adapt it to this repo:
* Adapt to the repo's folder structure:
  * Migrate pages/metadata to the "pages" folder
  * Migrate supporting images to a new "assets" folder (currently orphaned):
    * GCWeb already uses "assets" for its images
    * Jekyll's documentation states that it uses "assets" as a common convention (according to https://jekyllrb.com/docs/step-by-step/07-assets/)
  * Migrate CSS/JS into the repo's life-events.css/js files (with "Retirement Hub theme" comment headers)
* ESLint config:
  * Add a global "wb" variable to resolve the following error in the "eslint:target" task:
    * 'wb' is not defined (no-undef)
  * More info: https://eslint.org/docs/latest/rules/no-undef
* Pages:
  * Repo index page:
    * Add link to thematic page
  * Theme page:
    * Frontmatter:
      * Change YAML to JSON
      * Adjust thematic CSS/JS file references
    * Revise note paragraph:
      * Change "méli-mélo/th-vitality/vitality.html" reference into a GitHub Pages link (relative path doesn't make sense outside of the GCWeb repo)
      * Remove note about wrong CSS file references (it's correctly referring to its own CSS now)
    * Use tab indents consistently (was previously a mix of 4 spaces and tabs)
  * Metadata:
    * Rename componentName variable to "th-retirement-hub" (to make metadata retrievable by the theme page's Liquid logic)
    * Rename leftover "empathy" references to "retirement"/"retirement-hub"
EricDunsworth added a commit to EricDunsworth/canada-life-events that referenced this pull request Mar 6, 2026
@EricDunsworth
Repo: Port draft retirement life event thematic
5495ea8 
Port of wet-boew/GCWeb#2691 (Thematic: Retirement life event):
* Extremely preliminary
* Barely a thematic at this point (more like sloppy custom CSS than a thematic atm)
* Checklist has custom JS that hasn't made its way into this PR yet
* Needs way more work

Changes to adapt it to this repo:
* Adapt to the repo's folder structure:
  * Migrate pages/metadata to the "pages" folder
  * Migrate supporting images to a new "assets" folder (currently orphaned):
    * GCWeb already uses "assets" for its images
    * Jekyll's documentation states that it uses "assets" as a common convention (according to https://jekyllrb.com/docs/step-by-step/07-assets/)
  * Migrate CSS/JS into the repo's life-events.css/js files (with "Retirement Hub theme" comment headers)
* ESLint config:
  * Add a global "wb" variable to resolve the following error in the "eslint:target" task:
    * 'wb' is not defined (no-undef)
  * More info: https://eslint.org/docs/latest/rules/no-undef
* Pages:
  * Repo index page:
    * Add link to thematic page
  * Theme page:
    * Frontmatter:
      * Change YAML to JSON
      * Adjust thematic CSS/JS file references
    * Revise note paragraph:
      * Change "méli-mélo/th-vitality/vitality.html" reference into a GitHub Pages link (relative path doesn't make sense outside of the GCWeb repo)
      * Remove note about wrong CSS file references (it's correctly referring to its own CSS now)
    * Use tab indents consistently (was previously a mix of 4 spaces and tabs)
  * Metadata:
    * Rename componentName variable's value to "th-retirement-hub" (to make metadata retrievable by the theme page's Liquid logic)
    * Rename leftover "empathy" references to "retirement"/"retirement-hub"
@EricDunsworth EricDunsworth mentioned this pull request Mar 6, 2026
Merged
EricDunsworth added a commit to EricDunsworth/canada-life-events that referenced this pull request Mar 6, 2026
@EricDunsworth
Repo: Port draft retirement life event thematic
505af75 
Port of wet-boew/GCWeb#2691 (Thematic: Retirement life event):
* Extremely preliminary
* Barely a thematic at this point (more like sloppy custom CSS than a thematic atm)
* Checklist has custom JS that hasn't made its way into this PR yet
* Needs way more work

Changes to adapt it to this repo:
* Adapt to the repo's folder structure:
  * Migrate pages/metadata to the "pages" folder
  * Migrate supporting images to a new "assets" folder (currently orphaned):
    * GCWeb already uses "assets" for its images
    * Jekyll's documentation states that it uses "assets" as a common convention (according to https://jekyllrb.com/docs/step-by-step/07-assets/)
  * Migrate CSS/JS into the repo's life-events.css/js files (with "Retirement Hub theme" comment headers)
* ESLint config:
  * Add a global "wb" variable to resolve the following error in the "eslint:target" task:
    * 'wb' is not defined (no-undef)
  * More info: https://eslint.org/docs/latest/rules/no-undef
* Pages:
  * Repo index page:
    * Add link to thematic page
  * Theme page:
    * Frontmatter:
      * Change YAML to JSON
      * Adjust thematic CSS/JS file references
    * Revise note paragraph:
      * Change "méli-mélo/th-vitality/vitality.html" reference into a GitHub Pages link (relative path doesn't make sense outside of the GCWeb repo)
      * Remove note about wrong CSS file references (it's correctly referring to its own CSS now)
    * Use tab indents consistently (was previously a mix of 4 spaces and tabs)
  * Metadata:
    * Rename componentName variable's value to "th-retirement-hub" (to make metadata retrievable by the theme page's Liquid logic)
    * Rename leftover "empathy" references to "retirement"/"retirement-hub"
@EricDunsworth
Copy link
Copy Markdown
Member Author

EricDunsworth commented Mar 6, 2026 •
edited
Loading

This has been ported over to ServiceCanada/canada-life-events#12. That repo still needs a lot more work though since the aforementioned PR was an "as-is" port of where this PR stood in November 2025.

@duboisp Should I close-out this PR now? Or would you prefer that I leave it open until ServiceCanada/canada-life-events gets its first release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EricDunsworth @duboisp