[WV-2253] change header response to json #2997
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I also turned on the decorator for
backup_one_table_to_s3_viewin the interest of expediting functionality testing. This should not have any issue in prod due to all the try/except statements.The previous issue is that NGINX would remove headers that contained a period
.This caused the code to run fine in local, but error in production.
After looking into RFC standards (https://datatracker.ietf.org/doc/html/rfc7230) the best course of action is to send JSON bodies over token headers.
This changes
TokensManagerfunctions to send and handle headers as JSON now.Testing:
Tested functionality on local instance
Modified unit tests to handle
JSONand expect stringdatetimes.