Add configurable URL sorting with smart layout detection #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephschmitt
force-pushed
the
master
branch
2 times, most recently
from
41074ed to
41ec345
Compare
Adds a new option for `@fzf-url-sort-by`, defaulting to `alphabetical` as before, and adding `recency` to sort urls by recency in the scrollback history. Most of the time when I use this plugin, I want to open the url that just got printed (usually a github PR). Sorting be recency makes it so 9/10 times, I invoke the plugin and hit enter to oepn it right away.
wfxr
reviewed
Jul 19, 2025
Comment on lines
+70
to
+73
| if (!seen[url]) { | ||
| seen[url] = 1 | ||
| print $1 ":" url | ||
| } |
There was a problem hiding this comment.
If the same URL appears multiple times, shouldn’t we keep the line number of its last occurrence instead of the first?
There was a problem hiding this comment.
@wfxr Ohhh, that's an interesting idea. wdyt? I could go either way
There was a problem hiding this comment.
@josephschmitt IMO it's more intuitive to sort by the last occurrence. However, if this is much more complicated to implement, the current solution is acceptable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new option for
@fzf-url-sort-by, defaulting toalphabeticalas before, and addingrecencyto sort urls by recency in the scrollback history.Most of the time when I use this plugin, I want to open the url that just got printed (usually a github PR). Sorting be recency makes it so 9/10 times, I invoke the plugin and hit enter to open it right away. Setting
recencyto have links sorted by the order they appear in scrollback puts the most recent links closest to thefzfsearch bar. If you use--reversewithfzf, it’ll detect this and reverse the sort order to maintain the most recent url’s to be closest to the search bar and row selection.