Skip to content

Fix: Prevent IntegrityError on user deletion by handling missing user #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolandgeider merged 4 commits into from
Mar 2, 2026
+61 −0
Merged

Fix: Prevent IntegrityError on user deletion by handling missing user #2233

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d43afa
Fix IntegrityError during user deletion (#2232)
infektyd Mar 2, 2026
134f339
test: add unit test for UserStatisticsService.get_or_create_statistic…
infektyd Mar 2, 2026
ccb22e9
Add integration test for user deletion with trophy data per maintaine…
infektyd Mar 2, 2026
d124ded
tests: FIX UNIQUE constraint failed by using update_or_create for Use…
infektyd Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions wger/trophies/services/statistics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ def get_or_create_statistics(cls, user: User) -> UserStatistics:
Returns:
The UserStatistics instance
"""
if not User.objects.filter(pk=user.pk).exists():
raise User.DoesNotExist('User not found')
stats, created = UserStatistics.objects.get_or_create(user=user)
return stats

Expand Down
9 changes: 9 additions & 0 deletions wger/trophies/signals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

# Django
from django.conf import settings
from django.contrib.auth.models import User
from django.db.models.signals import (
post_delete,
post_save,
Expand Down Expand Up @@ -112,6 +113,8 @@ def workout_log_saved(sender, instance: WorkoutLog, created: bool, **kwargs):

# Trigger trophy evaluation
_trigger_trophy_evaluation(instance.user_id)
except User.DoesNotExist:
pass
except Exception as e:
logger.error(f'Error updating statistics for user {instance.user_id}: {e}', exc_info=True)

Expand All @@ -128,6 +131,8 @@ def workout_log_deleted(sender, instance: WorkoutLog, **kwargs):

try:
UserStatisticsService.handle_workout_deletion(instance.user)
except User.DoesNotExist:
pass
except Exception as e:
logger.error(
f'Error updating statistics after deletion for user {instance.user_id}: {e}',
Expand Down Expand Up @@ -163,6 +168,8 @@ def workout_session_saved(sender, instance: WorkoutSession, created: bool, **kwa

# Trigger trophy evaluation
_trigger_trophy_evaluation(instance.user_id)
except User.DoesNotExist:
pass
except Exception as e:
logger.error(f'Error updating statistics for session {instance.id}: {e}', exc_info=True)

Expand All @@ -179,6 +186,8 @@ def workout_session_deleted(sender, instance: WorkoutSession, **kwargs):

try:
UserStatisticsService.handle_workout_deletion(instance.user)
except User.DoesNotExist:
pass
except Exception as e:
logger.error(
f'Error updating statistics after session deletion for user {instance.user_id}: {e}',
Expand Down
Loading